Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No reseeding #6

Merged
merged 1 commit into from
Oct 16, 2017
Merged

No reseeding #6

merged 1 commit into from
Oct 16, 2017

Conversation

pitdicker
Copy link

This is just hacked together in half an hour, to see what would happen if we remove reseed and all the reseeding machinery.

@pitdicker
Copy link
Author

I have removed the second commit. Removing the ReseedingRng module is maybe a bit to enthusiastic.

@dhardy
Copy link
Owner

dhardy commented Oct 1, 2017

Thanks for separating the two changes out. Actually, it looks like you left a few of the reseeding changes in thread_local, remove them (for now at least) please?

It seems in general like removing reseed simplifies things nicely.

@pitdicker
Copy link
Author

Do you think the changes to tread-local may not be the right direction, or do you just want to do the change to reseed first?

(Removed the commit b.t.w.)

@dhardy
Copy link
Owner

dhardy commented Oct 1, 2017

I'd just rather keep the stuff separate. Not sure about ReseedingRng yet; it may be useful to keep as is.

@dhardy
Copy link
Owner

dhardy commented Oct 16, 2017

Thanks; lets merge this!

@dhardy dhardy merged commit dfdf89c into dhardy:master Oct 16, 2017
@pitdicker pitdicker deleted the no_reseeding branch October 21, 2017 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants